[#298] Update og:image, favicon, and Farcaster manifest assets#301
[#298] Update og:image, favicon, and Farcaster manifest assets#301realproject7 merged 4 commits intomainfrom
Conversation
- layout.tsx: add icons (favicon.png), openGraph.images and twitter.images (og-image.png) - farcaster.json: add splashImageUrl pointing to splash.png Fixes #298 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Blocking: The metadata references three assets that don't exist in /public:
/favicon.png— onlyicon.pngexists/og-image.png— missingsplash.png— missing (referenced in farcaster.json)
These will all 404. Either add the asset files to this PR or update the references to use the existing icon.png for favicon/icon. The OG image and splash image need actual files committed.
Note: the issue scope says "update metadata references for the new brand assets in /public" — suggests the assets should already be there. If they haven't been added yet, this PR should include them or the issue needs clarification from T1.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The layout metadata updates are correct, but the Farcaster manifest portion is still incomplete relative to issue #298.
Findings
- [medium]
farcaster.jsonstill omits the manifest OG/promotional image field.- File:
public/.well-known/farcaster.json:12 - Suggestion: Add
ogImageUrlpointing at the new/og-image.pngasset. Issue #298 explicitly asked for the OG/cover image field if the manifest supports it, and current mini app manifest docs do supportogImageUrl.
- File:
Decision
Requesting changes because the PR updates openGraph.images and twitter.images, but it does not complete the matching Farcaster manifest asset update required by the issue.
Include favicon.png, og-image.png, splash.png, icon.png, embed-image.png, and wide-banner.png — previously untracked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously untracked — referenced by NavBar (PR #299). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Previous blocker resolved — all referenced assets (favicon.png, og-image.png, splash.png) are now committed. Also includes icon.png update, plotlink-logo-symbol.svg, and bonus assets (embed-image.png, wide-banner.png). LGTM from my side.
Note: T2a's separate finding about ogImageUrl in farcaster.json is still outstanding.
Addresses T2a review: include OG/promotional image field in the mini app manifest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The missing Farcaster manifest image field has been added, and the referenced brand assets are now committed in the PR.
Findings
- No blocking findings.
Decision
Approving because the metadata updates now cover favicon, Open Graph, Twitter, and Farcaster manifest assets as required by issue #298.
Remove the "How to Get PLOT" section. Add USD equivalent below the PLOT balance amount using the existing token price data from useTokenInfo(). Only shown when balance > 0 and price is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Summary
icons,openGraph.images, andtwitter.imagesto the root layout metadata/favicon.png, OG and Twitter images set to/og-image.pngsplashImageUrlpointing tosplash.pngiconUrlalready correctly references/icon.pngFixes #298
Test plan
og:imagemeta tag renders/og-image.pngin page sourcetwitter:imagemeta tag is setfavicon.pngin browser tab/.well-known/farcaster.jsonincludessplashImageUrlnpm run buildpasses🤖 Generated with Claude Code